Skip to content
Snippets Groups Projects
  1. May 09, 2022
  2. Apr 24, 2022
    • Konrad Mohrfeldt's avatar
      fix: align schedule create/update conflict responses with documentation · 3af360ec
      Konrad Mohrfeldt authored
      The conflict responses should be send with an HTTP 409 status code as
      they’re defined in our documentation. This was not the case as the
      dashboard couldn’t handle these error codes, but is now fixed in
      dashboard@4a07ad9e.
      3af360ec
    • Konrad Mohrfeldt's avatar
      feat: allow single request scheduling · 293c78c5
      Konrad Mohrfeldt authored
      Until now the steering API client was expected to submit two requests.
      
      1. The initial schedule request, with a `schedule` object
      2. A second schedule request, with an additional `solutions` object
      
      This `solutions` object was empty, if no conflicts arose from the
      submitted schedule in the first place. But instead of just creating the
      requested schedule if no conflicts were detected we still required that
      second round-trip, introducing possible race conditions in the client,
      if another successful scheduling request was made between requests.
      
      From now on the steering API will create schedules if no conflicts have
      been detected and will only require the client to submit solutions if
      there really are conflicts to solve.
      293c78c5
    • Konrad Mohrfeldt's avatar
      refactor: update schedule REST API attribute names and documentation · 51be0fbe
      Konrad Mohrfeldt authored
      The following attribute names were marked as deprecated in the schedule
      request and have been replaced by their new names:
      
        dstart → first_date
        until → last_date
        tstart → start_time
        tend → end_time
        byweekday → by_weekday
      
      Apart from that this commit fixes a few documentation errors.
      51be0fbe
  3. Apr 23, 2022
  4. Apr 14, 2022
  5. Apr 07, 2022
  6. Mar 28, 2022
  7. Mar 23, 2022
  8. Mar 22, 2022
    • Konrad Mohrfeldt's avatar
      feat: return schedule dry-runs with a separate status code · 09c8642b
      Konrad Mohrfeldt authored
      Schedule dry-runs returned a 201 response before, because the only check
      for a 201 return code was, that the payload must not contain the
      "projected" keyword.
      
      As dry-runs don’t create any data 201 is not an appropriate status code.
      09c8642b
    • Konrad Mohrfeldt's avatar
      fix: don’t restrict timeslot queryset on detail views · eb3f33ac
      Konrad Mohrfeldt authored
      The filter defaults caused the queryset to always yield results filtered
      for the coming 60 days. We should only apply filter defaults when
      listing timeslots, not when querying individual items.
      eb3f33ac
    • Konrad Mohrfeldt's avatar
      fix: remove superfluous retrieve/update actions for APIUserViewSet · 0106797d
      Konrad Mohrfeldt authored
      The retrieve and update actions can be removed because the get_queryset
      method already ensures that the user has only access to their own user
      object (or all user objects in case of superusers).
      
      Sending 401 responses for unauthorized requests may also be considered
      leaky, because it exposes that these objects exist instead of returning
      a 404 that simply states that no object with that primary key can be
      found.
      0106797d
    • Konrad Mohrfeldt's avatar
      fix: always include API fields · 1b0a0ad5
      Konrad Mohrfeldt authored
      Simply omitting properties in the API in certain edge cases makes API
      client implementations brittle and documentation a lot harder.
      1b0a0ad5
    • Konrad Mohrfeldt's avatar
      fix: raise ValidationError on invalid data · 98dcfc5d
      Konrad Mohrfeldt authored
      This gives the calling code better control over the handling of such
      errors and makes it easy to differentiate between errors and valid
      return types.
      98dcfc5d
    • Konrad Mohrfeldt's avatar
      refactor: move subroute filtering into viewset mixin · 3507bbdb
      Konrad Mohrfeldt authored
      Most of the queryset filtering for subroutes formerly implemented
      through custom get_queryset methods can happen semi-automated through a
      mixin, making the behaviour re-usable and allowing us strip a lot of
      additional logic for retrieving objects.
      
      The use of the viewset get_object method also allows us to implement
      object access with permission classes in the future, and should make a
      whole lot of other code obselete.
      
      This change is primarily motivated by the fact that documentation of the
      API will become a lot easier if the subroutes don’t impose arbitrary
      restrictions on the specific subpath under which an operation is
      allowed. For instance updating a schedule should be possible through
      either /schedules/<pk>/ or
      /shows/<show_pk>/schedules/<schedule_pk>/ as long as all the necessary
      data is present in the request body.
      3507bbdb
    • Konrad Mohrfeldt's avatar
      refactor: implement consistent pk/slug retrieval for shows · f7926bd9
      Konrad Mohrfeldt authored
      The show retrieve method allowed shows to be identified through the slug
      or the id. This is handy, but was restricted to the retrieve and did not
      apply to the update nor delete methods. The proper way to implement this
      kind of behaviour is through overriding get_object so that route
      identifiers are handled consistently.
      f7926bd9
    • Konrad Mohrfeldt's avatar
      fix: cba_id should be part of the serialized representation · a03f60a2
      Konrad Mohrfeldt authored
      cba_id was always part of the serialized note representation through the
      use of `fields = "__all__"``and shouldn’t be write-only.
      a03f60a2
  9. Mar 21, 2022
  10. Mar 17, 2022
    • Konrad Mohrfeldt's avatar
      refactor: use django_filters FilterSet for APINoteViewSet · 7eaa0a49
      Konrad Mohrfeldt authored
      This change re-implements all existing collection filters for the
      APINoteViewSet with a FilterSet. No breaking changes are expected.
      7eaa0a49
    • Konrad Mohrfeldt's avatar
      refactor: tidy up APIScheduleViewSet · 29837872
      Konrad Mohrfeldt authored
      * TODOs are no longer part of the method description
      * normalized queryset handling
      * consistent formatting of method descriptions.
      29837872
    • Konrad Mohrfeldt's avatar
      refactor: pre-fill show and timeslot data on note creation · b3247ab5
      Konrad Mohrfeldt authored
      If notes are created through subroutes some of the data necessary to
      create a note is already available through the route data and doesn’t
      need to be passed as part of the request body anymore.
      b3247ab5
    • Konrad Mohrfeldt's avatar
      fix: fix typo causing note creations to fail · 0dc2903b
      Konrad Mohrfeldt authored
      Notes will only be created if called through a timeslot subroute. The
      typo prohibited the note creation, because timeslot_pk was always None
      and caused the view to error early.
      0dc2903b
    • Konrad Mohrfeldt's avatar
      feat: add string representations for models · 3bfec8a5
      Konrad Mohrfeldt authored
      This adds a string representation for all program models except the
      schedule so that it is easier to identify objects in DRF’s filter,
      create, and update forms.
      3bfec8a5
    • Konrad Mohrfeldt's avatar
      fix: fix audio_url generation for notes · 24f6f06d
      Konrad Mohrfeldt authored
      There were some problems during audio_url generation for notes:
      
      1. the cba_id was never part of the Note serializer so getting
         values from the validated data needed to fail.
      2. the get_audio_url utililty function returned None if
         no cba_id was provided if a the CBA_API_KEY was missing,
         but None but the respective model field is not nullable on the note.
      3. Request or JSON decoder errors would bubble unhandled, even though
         audio_url generation seems to be optional and should not necessarily
         interfere with note creation.
      24f6f06d
    • Konrad Mohrfeldt's avatar
      refactor: implement active filter for various viewsets · 2d9fd804
      Konrad Mohrfeldt authored
      APICategoryViewSet, APITypeViewSet, APITopicViewSet,
      APIMusicFocusViewSet, APIFundingCategoryViewSet, APILanguageViewSet, and
      APIHostViewSet all used the same base class implementing get_queryset
      for filtering by their active state. This is now handled by a generic
      FilterSet.
      2d9fd804
Loading