Skip to content
Snippets Groups Projects
  1. Mar 27, 2023
  2. Feb 24, 2023
  3. Feb 21, 2023
  4. Feb 17, 2023
  5. Nov 15, 2022
  6. Nov 14, 2022
  7. Oct 19, 2022
  8. Oct 15, 2022
  9. Oct 06, 2022
  10. Oct 04, 2022
  11. Sep 05, 2022
  12. Aug 17, 2022
  13. Aug 09, 2022
  14. Aug 08, 2022
  15. Aug 07, 2022
  16. Jul 28, 2022
  17. Apr 24, 2022
    • Konrad Mohrfeldt's avatar
      fix: align schedule create/update conflict responses with documentation · 3af360ec
      Konrad Mohrfeldt authored
      The conflict responses should be send with an HTTP 409 status code as
      they’re defined in our documentation. This was not the case as the
      dashboard couldn’t handle these error codes, but is now fixed in
      dashboard@4a07ad9e.
      3af360ec
    • Konrad Mohrfeldt's avatar
      feat: allow single request scheduling · 293c78c5
      Konrad Mohrfeldt authored
      Until now the steering API client was expected to submit two requests.
      
      1. The initial schedule request, with a `schedule` object
      2. A second schedule request, with an additional `solutions` object
      
      This `solutions` object was empty, if no conflicts arose from the
      submitted schedule in the first place. But instead of just creating the
      requested schedule if no conflicts were detected we still required that
      second round-trip, introducing possible race conditions in the client,
      if another successful scheduling request was made between requests.
      
      From now on the steering API will create schedules if no conflicts have
      been detected and will only require the client to submit solutions if
      there really are conflicts to solve.
      293c78c5
    • Konrad Mohrfeldt's avatar
      refactor: update schedule REST API attribute names and documentation · 51be0fbe
      Konrad Mohrfeldt authored
      The following attribute names were marked as deprecated in the schedule
      request and have been replaced by their new names:
      
        dstart → first_date
        until → last_date
        tstart → start_time
        tend → end_time
        byweekday → by_weekday
      
      Apart from that this commit fixes a few documentation errors.
      51be0fbe
  18. Mar 28, 2022
    • Konrad Mohrfeldt's avatar
      feat: add schema documentation with drf-spectacular · ec08012b
      Konrad Mohrfeldt authored
      This adds extensive API documentation based on the official API
      documentation [1] and conflict resolution [2] documents.
      
      Where possible field documentation was added to models or serializers,
      so that other code like auto-generated forms can also profit from these
      changes (hence the migration part of this commit).
      
      The changes introduce two new API endpoints.
      
      `/api/v1/schema/` exposes the API schema as an OpenAPI 3.0.3 document.
      The standard format is yaml but can be switched to JSON by appending the
      `?format=json` query parameter.
      
      `/api/v1/schema/swagger-ui/` renders a visual representation of the
      OpenAPI 3 specification with support for testing the individual API
      endpoints including authentication.
      
      [1]
      https://gitlab.servus.at/aura/meta/-/blob/ec3c753d34ccb0269969808ac7dc28fff2ff1648/docs/development/api-definition.md
      [2]
      https://gitlab.servus.at/aura/meta/-/blob/ec3c753d34ccb0269969808ac7dc28fff2ff1648/docs/development/conflict-resolution.md
      ec08012b
    • Konrad Mohrfeldt's avatar
      feat: return schedule dry-runs with a separate status code · b82b0435
      Konrad Mohrfeldt authored
      Schedule dry-runs returned a 201 response before, because the only check
      for a 201 return code was, that the payload must not contain the
      "projected" keyword.
      
      As dry-runs don’t create any data 201 is not an appropriate status code.
      b82b0435
    • Konrad Mohrfeldt's avatar
      fix: remove superfluous retrieve/update actions for APIUserViewSet · 5bc1f22b
      Konrad Mohrfeldt authored
      The retrieve and update actions can be removed because the get_queryset
      method already ensures that the user has only access to their own user
      object (or all user objects in case of superusers).
      
      Sending 401 responses for unauthorized requests may also be considered
      leaky, because it exposes that these objects exist instead of returning
      a 404 that simply states that no object with that primary key can be
      found.
      5bc1f22b
    • Konrad Mohrfeldt's avatar
      refactor: move subroute filtering into viewset mixin · a0e800d9
      Konrad Mohrfeldt authored
      Most of the queryset filtering for subroutes formerly implemented
      through custom get_queryset methods can happen semi-automated through a
      mixin, making the behaviour re-usable and allowing us strip a lot of
      additional logic for retrieving objects.
      
      The use of the viewset get_object method also allows us to implement
      object access with permission classes in the future, and should make a
      whole lot of other code obselete.
      
      This change is primarily motivated by the fact that documentation of the
      API will become a lot easier if the subroutes don’t impose arbitrary
      restrictions on the specific subpath under which an operation is
      allowed. For instance updating a schedule should be possible through
      either /schedules/<pk>/ or
      /shows/<show_pk>/schedules/<schedule_pk>/ as long as all the necessary
      data is present in the request body.
      a0e800d9
    • Konrad Mohrfeldt's avatar
      refactor: implement consistent pk/slug retrieval for shows · c650f609
      Konrad Mohrfeldt authored
      The show retrieve method allowed shows to be identified through the slug
      or the id. This is handy, but was restricted to the retrieve and did not
      apply to the update nor delete methods. The proper way to implement this
      kind of behaviour is through overriding get_object so that route
      identifiers are handled consistently.
      c650f609
  19. Mar 23, 2022
  20. Mar 22, 2022
    • Konrad Mohrfeldt's avatar
      feat: return schedule dry-runs with a separate status code · 09c8642b
      Konrad Mohrfeldt authored
      Schedule dry-runs returned a 201 response before, because the only check
      for a 201 return code was, that the payload must not contain the
      "projected" keyword.
      
      As dry-runs don’t create any data 201 is not an appropriate status code.
      09c8642b
    • Konrad Mohrfeldt's avatar
      fix: remove superfluous retrieve/update actions for APIUserViewSet · 0106797d
      Konrad Mohrfeldt authored
      The retrieve and update actions can be removed because the get_queryset
      method already ensures that the user has only access to their own user
      object (or all user objects in case of superusers).
      
      Sending 401 responses for unauthorized requests may also be considered
      leaky, because it exposes that these objects exist instead of returning
      a 404 that simply states that no object with that primary key can be
      found.
      0106797d
    • Konrad Mohrfeldt's avatar
      refactor: move subroute filtering into viewset mixin · 3507bbdb
      Konrad Mohrfeldt authored
      Most of the queryset filtering for subroutes formerly implemented
      through custom get_queryset methods can happen semi-automated through a
      mixin, making the behaviour re-usable and allowing us strip a lot of
      additional logic for retrieving objects.
      
      The use of the viewset get_object method also allows us to implement
      object access with permission classes in the future, and should make a
      whole lot of other code obselete.
      
      This change is primarily motivated by the fact that documentation of the
      API will become a lot easier if the subroutes don’t impose arbitrary
      restrictions on the specific subpath under which an operation is
      allowed. For instance updating a schedule should be possible through
      either /schedules/<pk>/ or
      /shows/<show_pk>/schedules/<schedule_pk>/ as long as all the necessary
      data is present in the request body.
      3507bbdb
    • Konrad Mohrfeldt's avatar
      refactor: implement consistent pk/slug retrieval for shows · f7926bd9
      Konrad Mohrfeldt authored
      The show retrieve method allowed shows to be identified through the slug
      or the id. This is handy, but was restricted to the retrieve and did not
      apply to the update nor delete methods. The proper way to implement this
      kind of behaviour is through overriding get_object so that route
      identifiers are handled consistently.
      f7926bd9
  21. Mar 21, 2022
  22. Mar 17, 2022
Loading