Sending a PUT request over endpoint /api/v1/timeslots/{pk}/ results in an error 500

added bug label

assigned to @nnrcschmdt

changed the description

changed milestone to %1.0-alpha2 — Precise Pheasant

changed the description

... it looks like I spoke a bit too early about using /api/v1/shows/{show_pk}/schedules/{schedule_pk}/timeslots/{timeslot_pk}/ as a workaround: While it's true that the large majority of requests pass, 1% or so still fails with exactly the same symptoms as described above. I've asked myself if this could be some random failure but then I tried to set the request for a specific timeslot that caused the error an AURA Sync. The request failed every time:

http -f PUT http://desktop10.orange.local/steering/api/v1/shows/739/schedules/77587/timeslots/119774/ \
'Authorization:Bearer $access_token' \
cba_id=null \
end=2022-06-01T00:00:00+02 \
is_repetion=true \
memo='no memo given' \
playlist_id=0 \
schedule=77587 \
show=739 \
start=2022-05-31T23:00:00+02

HTTP/1.1 500 Internal Server Error
Connection: keep-alive
Content-Type: text/html
Date: Mon, 14 Nov 2022 14:06:41 GMT
Server: nginx/1.22.1
Transfer-Encoding: chunked
Vary: Origin

<!doctype html>
<html lang="en">
<head>
  <title>Server Error (500)</title>
</head>
<body>
  <h1>Server Error (500)</h1><p></p>
</body>
</html>

In the logs I see the following (pretty much the same as for /api/v1/timeslots/{pk}/):

steering  | ERROR:django.request:Internal Server Error: /api/v1/shows/739/schedules/77587/timeslots/119774/
steering  | Traceback (most recent call last):
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner
steering  |     response = get_response(request)
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response
steering  |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
steering  |     return view_func(*args, **kwargs)
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/rest_framework/viewsets.py", line 125, in view
steering  |     return self.dispatch(request, *args, **kwargs)
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/rest_framework/views.py", line 509, in dispatch
steering  |     response = self.handle_exception(exc)
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/rest_framework/views.py", line 469, in handle_exception
steering  |     self.raise_uncaught_exception(exc)
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
steering  |     raise exc
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/rest_framework/views.py", line 506, in dispatch
steering  |     response = handler(request, *args, **kwargs)
steering  |   File "/steering/program/views.py", line 609, in update
steering  |     ts = TimeSlot.objects.filter(show=show_pk, start__gt=timeslot.start)[0]
steering  |   File "/root/.cache/pypoetry/virtualenvs/steering-UWcQ_v2w-py3.10/lib/python3.10/site-packages/django/db/models/query.py", line 318, in __getitem__
steering  |     return qs._result_cache[0]
steering  | IndexError: list index out of range

added Doing label

added 1 deleted label

closed with commit 37f858c2

removed Doing label

I still don't understand why we need to do this thing with the next repetition timeslot, but I fixed the code to avoid the exception when there is no repetition.

Looking at your request parameters:

cba_id doesn't exist for a timeslot and is silently ignored,
start, end, show and schedule are also ignored, they are not needed to get the timeslot and are not updated by the request,
only memo, is_repetition and playlist_id get updated by an API request in the main branch.

I'll backport the fix to the aep05 branch, where, for reference memo, repetition_of (the id of a timeslot) and playlist_id are updated.

Thanks @nnrcschmdt ! Just updated my local installation and I didn't get as single error 500! However:

start,end, show and schedule - though they may be ignored, are required (I get an error 400 if I omit them in the request).
I don't really understand why memo is mandatory. I haven't found a single entry in our old backend where this wasn't null. (I can, however, enter an empty string as I just found out)
cba_id was an oversight on my side - timeslots in our old backend do indeed include a field cba_id.

Anyway, this discussion probably exceeds the scope of this issue. I'm gonna continue in the matrix...

mentioned in commit 37f858c2

Sending a PUT request over endpoint /api/v1/timeslots/{pk}/ results in an error 500

Designs

Child items ...

Activity