Skip to content
Snippets Groups Projects
  1. Apr 24, 2022
    • Konrad Mohrfeldt's avatar
      refactor: update old schedule attribute names · cb84bfe6
      Konrad Mohrfeldt authored
      The steering API has some deprecated attribute names that we should no
      longer use. These are:
      
        dstart → first_date
        until → last_date
        tstart → start_time
        tend → end_time
        byweekday → by_weekday
      
      These changes in naming have also been applied to variable names,
      attribute names and translatations in the dashboard code in order to
      avoid confusion.
      cb84bfe6
    • Konrad Mohrfeldt's avatar
      feat: allow API store consumers to use traditional flow-control · f4da882f
      Konrad Mohrfeldt authored
      The currently prevalent API response handling is based on a callback
      pattern. This has at least two major drawbacks:
      
      1. More broadly it facilitates the use of nested callbacks, which make
         the code harder to read and clutter stack traces.
      2. Our specific callback solution does not follow the traditional node
         callback pattern that looks like `function (err, data) { ... }`.
         Instead we have `callback` and `callbackCancel`, none of which are
         meant to handle actual error/exception objects.
      
      The latter makes it hard to write code that is executed irrespective of
      the specific code path, like in a try-finally clause. In practice it’s
      also a violation of the separation-of-concerns design principle as it
      forces error handling to happen in the store function instead of the
      caller that is best suited to handle error states.
      
      This change attempts to facilitate a gradual migration to a
      Promise-based result handling by it to co-exist with the currently used
      callback pattern. Callers that don’t provide any callback functions are
      assumed to handle promises whereas callers that do provide callback
      functions will see no change in behaviour.
      
      This allows us to transition one API-call at a time instead of doing one
      large and time-consuming refactoring.
      
      refs #55
      f4da882f
    • Konrad Mohrfeldt's avatar
      feat: add has helper-function · 6fd3bef2
      Konrad Mohrfeldt authored
      6fd3bef2
    • Konrad Mohrfeldt's avatar
      refactor: clean up time & date functions · 1140b802
      Konrad Mohrfeldt authored
      * replace all `var` declarations and use `const` where appropriate
      * strip unnecessary temporary variables
      * replace single character variable names
      * replace multiline variable declarations
      * simplify expressions
      * replace invalid uses of parseInt
      1140b802
  2. Apr 23, 2022
  3. Apr 22, 2022
  4. Apr 21, 2022
  5. Mar 29, 2022
  6. Mar 28, 2022
  7. Mar 25, 2022
  8. Mar 18, 2022
  9. Mar 17, 2022
  10. Jan 14, 2022
  11. Dec 09, 2021
  12. Dec 03, 2021
Loading