chore: simplify choice generation

src/components/shows/AddShowModal.vue

@@ -123,25 +123,14 @@
             },
 
             showTypeSelector: function () {
-                let options = []
-                for (let i in this.types) {
-                    options.push({
-                        value: this.types[i].id,
-                        text: this.types[i].type
-                    })
-                }
-                return options
+              return this.types.map(({type, id}) => ({text: type, value: id }))
             },
 
             showFundingCategorySelector: function () {
-                let options = []
-                for (let i in this.fundingcategories) {
-                    options.push({
-                        value: this.fundingcategories[i].id,
-                        text: this.fundingcategories[i].abbrev + ' (' + this.fundingcategories[i].fundingcategory + ')'
-                    })
-                }
-                return options
+              return this.fundingcategories.map(({id, abbrev, fundingcategory}) => ({
+                value: id,
+                text: `${abbrev} (${fundingcategory})`
+              }))
             },
 
             ...mapGetters({