for week-based recurrence schemes, only every second timeslot gets created

When creating a new show with a week-based recurrence scheme, there is only every second timeslot created, while the recurrence scheme is correctly displayed on the Show Info Page. Creating a Wiederholungsprogramm on the same day & time (also with a weekly schedule) seemed not trigger the collision detection. (I tested this on 20/11/23 with the current version of dashboard.aura.radio in Firefox/Ubuntu)

changed milestone to %1.0-alpha5 — Capable Capybara

added P1 bug labels

assigned to @eigenwijsje

When testing again, I did the following steps to find out more precisely what is going on:

1. activate show
2. creating new recurrence schemes, using all different types of rhythms available: a 2-weekly rhythm, a odd/even-week-rhythm, a xth-week-of-month-rhythm a daily and a workday-wise rhythm
3. the result was that only every second timeslot got created for all the week-based schemes (weekly/2-weekly/4-weekly), while the daily and the workday-wise rhythm (e.g. every Friday) worked all fine, also regarding the collision management. When using the other schemes, creation of the schedules was refused / not possible at all.

Tested on dashboard.aura.radio on 21/11/23 using Firefox on Ubuntu.

So I am also precising the ticket description because it seems like a more general issue regarding creation of schedules and timeslots. Maybe it also makes sense to break this up into several smaller tickets @eigenwijsje ?

fyi - I created for recurrence schemes other than daily and wee... (#182 - closed) for the issue regarding the schedules.

changed title from for weekly recurrence scheme, timeslots get created only every second week to for week-based recurrence schemes, only every second timeslot gets created

changed the description

@fm_margarethem changing milestone to alpha-3, because if this bug can be confirmed, it looks like a blocking defect mandatory to be fixed before the release.

agree, this is a crucial feature. @eigenwijsje could you look into that and if necessary we can briefly assess this in the next upcoming meeting on Friday. I will also do some more extensive testing to see if we can even more precisely describe what is going on.

I tested with all available recurrence schemes and found that using the work-day / "werktäglich" rhythm creates only one timeslot per week (on the selected day). Using "daily" works as intended. For all rhythms that are not daily, or week-based (which means, odd/even calendar week, xth week of month), the creation of a schedule fails, meaning after entering the information in the UI, nothing happens at all.

Maybe one of us can validate this quickly just to be sure that no browser/network-related issues from my side are involved.

changed milestone to %1.0-alpha3 — Playful Platypus

added 1 deleted label

added To Do label

marked this issue as related to #182 (closed)

First, the deployment at dashboard.aura.radio only supports "once", "daily", "weekly" and "bi-weekly" recurrence rules.

A schedule with another recurrence rule cannot be created.

I see a lot of errors in the log entries because "RRule matching query does not exist".

If the dashboard offers other recurrence rules, then it's wrong.

steering exposes the supported recurrence rules at https://dashboard.aura.radio/steering/api/v1/rrules/.

[
    {
        "id": 1,
        "name": "einmalig"
    },
    {
        "id": 2,
        "name": "täglich"
    },
    {
        "id": 3,
        "name": "wöchentlich"
    },
    {
        "id": 4,
        "name": "zweiwöchentlich"
    },
    {
        "id": 5,
        "name": "vierwöchentlich"
    }
]

I will update the API to return an error, instead of simply throwing an exception and logging it, when a schedule cannot be created.

Thanks @eigenwijsje for the clarification. I sum up the main points here that resulted from our investigation on this issue yesterday:

1. Aura's datamodel can "speak" all kinds of different rrules (see AEP06), but only the rrules that get imported when loading a radio database, are then available for use in the AURA dashboard.
2. Since the AURA instance on dashboard.aura.radio is using the dataset of Radio Helsinki, currently only the rrules used at RH are working there. (Those are: once, daily, weekly, every 2nd /4th week. See post above.)
3. The dashboard should check the present rrules and display only the options that are offered via the database. So the actual error is that the recurrence selector menu offers rrules which are not present in the system. Adding an error message from steering, like @eigenwijsje did, is an improvement that helps for clarification and troubleshooting purposes. But possibly something is going wrong in communication between dashboard and steering? This needs to be investigated further (cc @kmohrf - maybe you can help to clarify).

To conclude, the question about the schedules (for recurrence schemes other than daily and wee... (#182 - closed)) from steering-side is solved. So shall we move this issue to the dashboard or assign it to @kmohrf for further investigation (cc @kmohrf @david )?

Also the issue about the missing timeslots remains, we have to look further into that.

instead of moving the ticket, I created a corresponding dashboard issue with a more precise issue description: dashboard#226 (closed)

So the actual error is that the recurrence selector menu offers rrules which are not present in the system.

Exactly. It looks like the rrules are currently hardcoded in Dashboard. Instead they should be dynamically loaded from Steering, displaying only available rules.

@eigenwijsje It's good that you now return an error code, when users trying operations with invalid rrules. I'd only recommend to avoid the German language in status code details, since we keep all technical aspects in English.

Since the AURA instance on dashboard.aura.radio is using the dataset of Radio Helsinki, currently only the rrules used at RH are working there. (Those are: once, daily, weekly, every 2nd /4th week. See post above.)

Since dashboard.aura.radio is also our current testing instance, I would highly appreciate if we also import all rrules there, being able to cover all test cases. While the test data is derived from RH, we don't need to stick with RHs planning logic. @fm_margarethem @eigenwijsje

I agree that we should carefully review the requirements for our online demo instance to make sure it is well equipped for upcoming testcases, but please let's keep the debate here in scope of this ticket.

to collect remarks and requests for improvements regarding our online dashboard demo, I created this ticket: Suggestions for improvements of online demo ins... (aura#258 - closed)

mentioned in issue #182 (closed)

marked this issue as related to #183 (closed)

marked this issue as related to dashboard#226 (closed)

After reviewing the database, meaning the schedules and timeslots created, it looks like a mismatch of the recurrence rules is the source of confusion.

This now works as expected.

closed

removed To Do label

I am sorry, I tested this again and the error persists Did you test it on dashboard.aura.radio? Maybe @kmohrf can help.

reopened

marked this issue as related to aura#258 (closed)

added To Do label

I should have been explicit before.

I can see five shows created by @fm_margarethem :

steering=# select id,name from program_show where created_by ='maggie';
 id |           name           
----+--------------------------
  3 | Hallo Welt
  7 | alles was geht
  8 | Neue Sendung
  9 | Fünf Minuten Nachrichten
 11 | Die Musikminute
(5 rows)

For these shows there are seven schedules, one is "once", one is "weekly" five are "bi-weekly":

steering=# select show.name, schedule.show_id, schedule.id, schedule.rrule_id, rrule.name from program_schedule as schedule join program_rrule as rrule on rrule.id = schedule.rrule_id join program_show as show on show.id=schedule.show_id where show_id in (3,7,8,9,11);
           name           | show_id | id | rrule_id |      name       
--------------------------+---------+----+----------+-----------------
 Fünf Minuten Nachrichten |       9 | 17 |        1 | einmalig
 Fünf Minuten Nachrichten |       9 | 23 |        3 | wöchentlich
 alles was geht           |       7 | 12 |        4 | zweiwöchentlich
 Fünf Minuten Nachrichten |       9 | 16 |        4 | zweiwöchentlich
 Fünf Minuten Nachrichten |       9 | 21 |        4 | zweiwöchentlich
 Fünf Minuten Nachrichten |       9 | 35 |        4 | zweiwöchentlich
 Fünf Minuten Nachrichten |       9 | 36 |        4 | zweiwöchentlich
(7 rows)

The timeslots for the weekly schedule (23) are created as expected:

steering=# select * from program_timeslot where schedule_id = 23;
 id |         start          |          end           | memo | playlist_id | schedule_id | repetition_of_id 
----+------------------------+------------------------+------+-------------+-------------+------------------
 65 | 2023-12-22 04:45:00+01 | 2023-12-22 05:00:00+01 |      |             |          23 |                 
 66 | 2023-12-29 04:45:00+01 | 2023-12-29 05:00:00+01 |      |             |          23 | 

This works as expected within steering and its database.

The source: dashboard has "hard-coded" the wrong values.

Nothing to be done in steering.

closed

removed To Do label

mentioned in issue dashboard#229 (closed)

Dear Ernesto, thanks for the detailed clarification! I created a dashboard ticket for further inspection.