Code is not formatted according to pre-commit rules

Parent: [EPIC] Coding Conventions: Setup pre-commit and... (aura#110 - closed)

When committing code I’ve noticed that old code is reformatted that I haven’t even touched.

After running pipx run black==23.7.0 --check . in the repository a lot of files were marked as invalid. I guess that after c31798df has been comitted, some of the styles black applies have changed compared to previous versions of black.

I see two tasks:

• The code should be reformatted according to the black version specified in .pre-commit-config.yaml
• A lint CI job should be added that automatically checks the code style (and maybe should parse the black version from the .pre-commit-config.yaml so they can’t diverge)

assigned to @eigenwijsje

marked this issue as related to #87 (closed)

According to #87 (closed) this was already integrated. I'm add a reference the parent epic and undoing the checked task.

changed milestone to %1.0-alpha7 — Helpful Hedgehog

changed the description

marked this issue as related to aura#110 (closed)

mentioned in issue aura#110 (closed)

changed milestone to %1.0-alpha3 — Playful Platypus

added P2 label

added To Do label

added 1 deleted label

removed 1 deleted label

removed To Do label

added To Do label

removed P2 label

added P3 label

changed milestone to %1.0-alpha5 — Capable Capybara

removed To Do label

marked this issue as related to #216

removed the relation with #216

added size:s label

Increasing priority to P1 for two reasons:

• After more people are committing code to Steering now, a common format is important.
• The parent epic aura#110 (closed) is open for a long time already.

added P1 label and removed P3 label

added Doing label

marked the checklist item The code should be reformatted according to the black version specified in .pre-commit-config.yaml as completed

marked the checklist item A lint CI job should be added that automatically checks the code style (and maybe should parse the black version from the .pre-commit-config.yaml so they can’t diverge) as completed

From the log of the job:

...
$ poetry run flake8 program steering
$ poetry run isort program steering
$ poetry run black program steering
All done! ✨ 🍰 ✨
154 files left unchanged.
Cleaning up project directory and file based variables
Job succeeded

Sweet! Thank you.

closed

removed Doing label

added Cycle [3/24] label

added 2h 30m of time spent

mentioned in issue #210 (closed)