Skip to content
Snippets Groups Projects
Verified Commit 705c9145 authored by Ole Binder's avatar Ole Binder
Browse files

Chore: add various FIXME comments

parent b07327fe
No related branches found
No related tags found
1 merge request!17Yaml configuration file
......@@ -46,7 +46,9 @@ def on_metadata_notification(meta) =
log(
level=3,
label="metadata",
"Detected FALLBACK channel `#{channel_name}` playing (Show ID: #{fallback_show_id()})"
"Detected FALLBACK channel `#{channel_name}` playing (Show ID: #{
fallback_show_id()
})"
)
show_name := fallback_show_name()
show_id := fallback_show_id()
......@@ -76,6 +78,7 @@ def on_metadata_notification(meta) =
"Skip posting playlog because of missing show ID!"
)
else
# FIXME: should we run this in a thread? Because if this breaks, the playout stops
post_playlog(engine_api_playlog, playlog)
end
end
......@@ -81,7 +81,7 @@ def attach_fallback_source(main_stream) =
reload_mode="seconds"
)
s = amplify(id="fallback_folder", 1., override="replay_gain", s)
# s = amplify(id="fallback_folder", 1., override="replay_gain", s)
# s = replaygain(s)
s = source.on_track(id="fallback_folder", s, on_fallback_notify)
......@@ -107,6 +107,7 @@ def attach_fallback_source(main_stream) =
reload=0
)
# FIXME: this may be the cause for the fallback to be so loud.
s = amplify(id="fallback_playlist", 1., override="replay_gain", s)
# s = replaygain(s)
......
......@@ -37,6 +37,7 @@ input_queue_raw_0 = request.queue(id="in_queue_01")
input_queue_raw_1 = request.queue(id="in_queue_12")
# Apply ReplayGain normalization, if metadata available
#FIXME: this causes issues with the volume?
input_queue_0 =
amplify(id="in_queue_0", 1., override="replay_gain", input_queue_raw_0)
input_queue_1 =
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment