Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
engine-core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AURA
engine-core
Commits
705c9145
Verified
Commit
705c9145
authored
7 months ago
by
Ole Binder
Browse files
Options
Downloads
Patches
Plain Diff
Chore: add various FIXME comments
parent
b07327fe
No related branches found
No related tags found
1 merge request
!17
Yaml configuration file
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
src/events.liq
+4
-1
4 additions, 1 deletion
src/events.liq
src/in_fallback.liq
+2
-1
2 additions, 1 deletion
src/in_fallback.liq
src/in_queue.liq
+1
-0
1 addition, 0 deletions
src/in_queue.liq
with
7 additions
and
2 deletions
src/events.liq
+
4
−
1
View file @
705c9145
...
...
@@ -46,7 +46,9 @@ def on_metadata_notification(meta) =
log(
level=3,
label="metadata",
"Detected FALLBACK channel `#{channel_name}` playing (Show ID: #{fallback_show_id()})"
"Detected FALLBACK channel `#{channel_name}` playing (Show ID: #{
fallback_show_id()
})"
)
show_name := fallback_show_name()
show_id := fallback_show_id()
...
...
@@ -76,6 +78,7 @@ def on_metadata_notification(meta) =
"Skip posting playlog because of missing show ID!"
)
else
# FIXME: should we run this in a thread? Because if this breaks, the playout stops
post_playlog(engine_api_playlog, playlog)
end
end
This diff is collapsed.
Click to expand it.
src/in_fallback.liq
+
2
−
1
View file @
705c9145
...
...
@@ -81,7 +81,7 @@ def attach_fallback_source(main_stream) =
reload_mode="seconds"
)
s = amplify(id="fallback_folder", 1., override="replay_gain", s)
#
s = amplify(id="fallback_folder", 1., override="replay_gain", s)
# s = replaygain(s)
s = source.on_track(id="fallback_folder", s, on_fallback_notify)
...
...
@@ -107,6 +107,7 @@ def attach_fallback_source(main_stream) =
reload=0
)
# FIXME: this may be the cause for the fallback to be so loud.
s = amplify(id="fallback_playlist", 1., override="replay_gain", s)
# s = replaygain(s)
...
...
This diff is collapsed.
Click to expand it.
src/in_queue.liq
+
1
−
0
View file @
705c9145
...
...
@@ -37,6 +37,7 @@ input_queue_raw_0 = request.queue(id="in_queue_01")
input_queue_raw_1 = request.queue(id="in_queue_12")
# Apply ReplayGain normalization, if metadata available
#FIXME: this causes issues with the volume?
input_queue_0 =
amplify(id="in_queue_0", 1., override="replay_gain", input_queue_raw_0)
input_queue_1 =
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment