Skip to content
Snippets Groups Projects
  1. Nov 08, 2022
  2. Apr 24, 2022
    • Konrad Mohrfeldt's avatar
      fix: properly handle steering scheduling API errors · e01a3692
      Konrad Mohrfeldt authored
      The steering API returns HTTP 400 errors for general payload and 409
      errors for scheduling conflicts that we didn’t handle yet.
      
      fixes #93
      e01a3692
    • Konrad Mohrfeldt's avatar
      feat: allow API store consumers to use traditional flow-control · f4da882f
      Konrad Mohrfeldt authored
      The currently prevalent API response handling is based on a callback
      pattern. This has at least two major drawbacks:
      
      1. More broadly it facilitates the use of nested callbacks, which make
         the code harder to read and clutter stack traces.
      2. Our specific callback solution does not follow the traditional node
         callback pattern that looks like `function (err, data) { ... }`.
         Instead we have `callback` and `callbackCancel`, none of which are
         meant to handle actual error/exception objects.
      
      The latter makes it hard to write code that is executed irrespective of
      the specific code path, like in a try-finally clause. In practice it’s
      also a violation of the separation-of-concerns design principle as it
      forces error handling to happen in the store function instead of the
      caller that is best suited to handle error states.
      
      This change attempts to facilitate a gradual migration to a
      Promise-based result handling by it to co-exist with the currently used
      callback pattern. Callers that don’t provide any callback functions are
      assumed to handle promises whereas callers that do provide callback
      functions will see no change in behaviour.
      
      This allows us to transition one API-call at a time instead of doing one
      large and time-consuming refactoring.
      
      refs #55
      f4da882f
  3. Apr 22, 2022
  4. Nov 18, 2021
  5. Nov 24, 2020
  6. Oct 13, 2020
  7. Sep 14, 2020
  8. Sep 08, 2020
  9. Aug 26, 2020
    • jackie / Andrea Ida Malkah Klaura's avatar
      fix show update loading info · b1565f06
      jackie / Andrea Ida Malkah Klaura authored
      when updating only single items we should not set the
      show loading info to true. otherwhise the whole ShowManager
      sub components will be reloaded. also it is not true
      that the show is loading.
      
      if we want to indicate an ongoing update of the show, we should
      introduce a specific flag for that.
      b1565f06
  10. Aug 25, 2020
  11. Aug 24, 2020
  12. Jun 11, 2020
  13. May 29, 2020
  14. May 15, 2020
  15. May 14, 2020
  16. May 07, 2020
  17. May 06, 2020
  18. May 04, 2020
  19. May 01, 2020
  20. Apr 30, 2020
  21. Apr 27, 2020
  22. Dec 08, 2019
Loading