Playlist.entries missing in Playlist REST API responses

Though documented in the API definition of the playlist REST API endpoints, neither requests to /playlists nor /playlists/:id return a list of PlaylistEntry in the entries property of the playlist objects. In fact, the entries property is missing entirely.

This is also responsible for a bug in the dashboard, preventing users from assigning a playlist to a timeslot of a show (see dashboard#119 (closed)).

If the entries list was omitted on purpose we should update the documentation accordingly.

mentioned in issue dashboard#88 (closed)

@kmohrf I don't think that's related:

This is also responsible for a bug in the dashboard, preventing users from assigning a playlist to a timeslot of a show (see dashboard#88 (closed)).

The mentioned ticket is only about Timeslots (= Steering). There is no playlist behavior (= Tank) involved. See my comments in the other ticket.

mentioned in issue dashboard#119 (closed)

changed the description

This only happens if no entries have been assigned to the playlist. But in that case entries should be an empty list and not be missing from the serialized object.

The store/types.go file contains the following lines (store/types.go#L224 for future reference):

type Playlist struct {
        ...
	Entries     []PlaylistEntry `json:"entries,omitempty"`
}

Deleting omitempty fixes the issue. This line was commited in June 2018 so tank has always worked this way. I probably could work around this in the dashboard but personally find this sort of behavior very confusing. We should review object serialization at the very least for all array structures.

assigned to @nnrcschmdt

added P2 label

changed milestone to %1.0-alpha2 — Precise Pheasant

added bug label

marked this issue as related to dashboard#119 (closed)

mentioned in commit dashboard@d0319c03

closed with commit decf0875