Provide a proper shell entrypoint

Currently, make is used as an entrypoint, but make is not the right tool for this.

The Makefile now also contains some tasks for local development.

A shell script should replace these targets in the Makefile:

• initialize,
• create_oidc_client.{dashboard,tank},
• delete_oidc_clients
• showmigrations,
• migrate,
• collectstatic,
• loaddata.{program,sample,custom,test}
• addpermissions,
• addtimeslots,
• removestaleimages,
• run.{dev,debug,production}

These are just wrappers around Django management commands.

The Makefile should only contain targets for local development:

• dev.install,
• format,
• test,
• release.

added To Do label

assigned to @eigenwijsje

changed milestone to %1.0-alpha5 — Capable Capybara

added size:s label

changed the description

added P2 label

@eigenwijsje what are the benefits of a shell script over a Makefile?

Seriously?

Compare this

TANK_CALLBACK_BASE_URL=${TANK_CALLBACK_BASE_URL:-${AURA_PROTO}://${AURA_HOST}/tank}

With this

ifndef TANK_CALLBACK_BASE_URL
override TANK_CALLBACK_BASE_URL = "${AURA_PROTO}://${AURA_HOST}/tank"
endif

I will only keep the targets that have more steps in the new entrypoint:

• initialize,
• create_oidc_clients,
• run.prod and run.dev, with run.prod as the default.

The remainder of the targets can be replaced with docker compose execute calls, for example:

Instead of running (and removing) this:

$ docker compose run --rm steering delete_oidc_clients

It’s even cleaner to execute this in the already running container:

$ docker compose exec steering poetry run ./manage.py delete_oidc_clients dashboard tank

The calls are a bit longer but they are not frequent. I will update the documentation.

It’s all about separation of concerns.

Let’s do things inside the container in the entrypoint or by executing the management commands inside the container and keep the local development tasks in the Makefile.

marked this issue as related to #224 (closed)

added Doing label and removed To Do label

closed with commit 44c378c8

removed Doing label

added Cycle [3/24] label

added 50m of time spent