`type` on Link models is a string instead of LinkType

There are a lot of models that implement Links but implement the type attribute as a string and not as a relation to the LinkType model. This blocks the implementation of dashboard#186 (closed).

changed milestone to %1.0-alpha3 — Playful Platypus

added P1 label

assigned to @eigenwijsje

marked this issue as related to dashboard#186 (closed)

added 1 deleted label

mentioned in issue dashboard#186 (closed)

added To Do label

The idea for using the string and not the ID was to keep the link and the type working when the LinkType is deleted.

This was the simplest way to accomplish this that I could think of at the time.

The list of supported link types is exposed by steering at /api/v1/link-types/, https://dashboard.aura.radio/steering/api/v1/link-types/

A sample fixture is provided and they can be managed using either the API or (for the time being) the admin interface.

We can start using the type IDs, but it would need an is_active field in the LinkType,

We would also need changes the logic of the /api/v1/link-types route

• list only the active objects,
• mark an object as inactive on delete.

And, additionally we would need to only allow active link types to be used when adding links to hosts, shows and notes...

Super. Yes let's go that route by making real references and adding the is_active flag to link types.

We would also need changes the logic of the /api/v1/link-types route

• list only the active objects,
• mark an object as inactive on delete.

I agree, that using an in-/active flag is a feasible solution. They delete should mark as inactive.

But let's not go for an implicit logic for the "list link-types" endpoint, by hiding inactive ones. This endpoint should return all available types, no matter if active or inactive. Dashboard can decide itself how to deal with state, what to use based on the is_active flag in the returned objects. E.g. Websites require also the information of inactive types, since they still might display old link types, which cannot be added in the new UI anymore.

Edit: In the future Dashboard should be able to manage all the link types too, including enabling/disabling. That's another reason the API should not be opinionated what to return, rather return all results.

added Doing label and removed To Do label

mentioned in commit 7b76a9c4

The implementation is done in the develop branch.

closed

removed Doing label