Use _id suffix for all object reference in REST APIs

Parent: [EPIC] Use _id suffix for all object reference ... (aura#166 - closed)

changed milestone to %1.0-alpha2 — Precise Pheasant

added 1 deleted label

assigned to @eigenwijsje

mentioned in issue aura#166 (closed)

added P2 label

added To Do label

added Doing label and removed To Do label

mentioned in commit bb9218c3

Every field that refers to an object has now the suffix Id or Ids in the REST API.

closed

removed Doing label

I’ve noticed an issue, and will post any additional findings here:

• Note still has contributors field
• Profile still has user field
• Collision still has repetitionOf field
• Host still has image field
• make_conflicts schedule object still has rrule and show fields. Possible fix:

  diff --git a/program/services.py b/program/services.py
  index 005192d..186c0e5 100644
  --- a/program/services.py
  +++ b/program/services.py
  @@ -29,6 +29,7 @@ from django.forms.models import model_to_dict
   from django.utils import timezone
   from django.utils.translation import gettext_lazy as _
   from program.models import Note, RRule, Schedule, ScheduleConflictError, Show, TimeSlot
  +from program.serializers import ScheduleSerializer
   from program.utils import parse_date, parse_datetime, parse_time
   from steering.settings import (
       AUTO_SET_LAST_DATE_TO_DAYS_IN_FUTURE,
  @@ -440,7 +441,7 @@ def make_conflicts(data: ScheduleData, schedule_pk: int | None, show_pk: int) ->
       conflicts = generate_conflicts(timeslots)
   
       # create a new dictionary by adding "schedule" to conflicts
  -    return dict(conflicts, schedule=model_to_dict(new_schedule))
  +    return dict(conflicts, schedule=ScheduleSerializer().to_representation(new_schedule))

• There are other uses of model_to_dict in the conflict resolution module that might need to be replaced.

reopened

mentioned in commit c2c3a9cc

I have also replaced the use of model_to_dict in five places.

closed