Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
steering
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
AURA
steering
Commits
fb680086
Verified
Commit
fb680086
authored
1 year ago
by
Ernesto Rico Schmidt
Browse files
Options
Downloads
Patches
Plain Diff
fix: return an empty user queryset if the user is unaunthenticated
parent
8708bdbd
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
program/views.py
+6
-3
6 additions, 3 deletions
program/views.py
with
6 additions
and
3 deletions
program/views.py
+
6
−
3
View file @
fb680086
...
...
@@ -265,12 +265,15 @@ class APIUserViewSet(
search_fields
=
[
"
username
"
,
"
first_name
"
,
"
last_name
"
,
"
email
"
]
def
get_queryset
(
self
):
"""
The queryset contains all the users if the method is safe or requesting user is a
superuser, otherwise it only contains the requesting user.
"""
"""
The queryset is empty if the user is not authenticated, contains all the users if the
method is safe or the requesting user is a superuser, otherwise it only contains the
requesting user.
"""
user
=
self
.
request
.
user
if
self
.
request
.
method
in
permissions
.
SAFE_METHODS
or
user
.
is_superuser
:
if
not
user
.
is_authenticated
:
return
User
.
objects
.
none
()
elif
self
.
request
.
method
in
permissions
.
SAFE_METHODS
or
user
.
is_superuser
:
return
User
.
objects
.
all
()
else
:
return
User
.
objects
.
filter
(
pk
=
user
.
id
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment