Skip to content
Snippets Groups Projects
  • Konrad Mohrfeldt's avatar
    24f6f06d
    fix: fix audio_url generation for notes · 24f6f06d
    Konrad Mohrfeldt authored
    There were some problems during audio_url generation for notes:
    
    1. the cba_id was never part of the Note serializer so getting
       values from the validated data needed to fail.
    2. the get_audio_url utililty function returned None if
       no cba_id was provided if a the CBA_API_KEY was missing,
       but None but the respective model field is not nullable on the note.
    3. Request or JSON decoder errors would bubble unhandled, even though
       audio_url generation seems to be optional and should not necessarily
       interfere with note creation.
    24f6f06d
    History
    fix: fix audio_url generation for notes
    Konrad Mohrfeldt authored
    There were some problems during audio_url generation for notes:
    
    1. the cba_id was never part of the Note serializer so getting
       values from the validated data needed to fail.
    2. the get_audio_url utililty function returned None if
       no cba_id was provided if a the CBA_API_KEY was missing,
       but None but the respective model field is not nullable on the note.
    3. Request or JSON decoder errors would bubble unhandled, even though
       audio_url generation seems to be optional and should not necessarily
       interfere with note creation.