Skip to content
Snippets Groups Projects
Commit 9a239a55 authored by David Trattnig's avatar David Trattnig
Browse files

docs: add ticket refs to reviewed TODO items

parent 6f7a13a7
No related branches found
No related tags found
No related merge requests found
Pipeline #2720 passed
......@@ -57,7 +57,7 @@
</span>
</span>
<!-- #FIXME show name should be something like "show_name" or "episode.show.name" in API -->
<!-- #FIXME show name should be something like "show_name" or "episode.show.name" in API (@see steering#97) -->
{#if episode.name}
<span class="episode-show-name">
<Display value={episode.name} {renderHtml} />
......
......@@ -87,7 +87,7 @@
<div class="timeslot-header">
<div class="show-title">
<!-- #FIXME "episode.title" should be "episode.show_title" or for consistency "episode.show.title" // show "random order" doesn't follow this structure -->
<!-- #FIXME "episode.title" should be "episode.show_title" or for consistency "episode.show.title" // show "random order" doesn't follow this structure (@see steering#97) -->
<Display value={episode.title} {renderHtml} />
</div>
</div>
......@@ -102,7 +102,7 @@
</p>
</a>
{:else if hasEpisodeTitle(episode)}
<!-- #FIXME "emmission_ID" should be "timeslot_id", "episode_id" or "id" only -->
<!-- #FIXME "episode.emmission_ID" should be "episode.timeslot_id", "episode.episode_id" or "episode.id" only (@see steering#97) -->
<a href={urlEpisodeDetail + episode.emission_ID}>
<h2 class="episode-title">
<Display value={episode.note_title} {renderHtml} />
......
......@@ -31,6 +31,7 @@
/** Checks if the given episode has a title set, indicating it's populated at all */
export function hasEpisodeTitle(episode) {
// #FIXME "episode.note_title" should be "episode.note.title"
// @see https://gitlab.servus.at/aura/steering/-/issues/97
// if (episode.note && episode.note.title && episode.note.title.trim())
if (episode.note_title && episode.note_title.trim()) return true
return false
......@@ -166,6 +167,7 @@
/* Creates virtual timeslots for empty timeslots (temporary o94 workaround) */
// #TODO missing timeslots should be populated server-site
// @see steering#97
export function fillEmptyTimeslots(programme, urlDefaultFallbackShow) {
let newProgramme = []
for (let i = 0; i < programme.length; i++) {
......
......@@ -41,6 +41,7 @@
// - show image
//
// There should be no need to do an additional show query
// @see https://gitlab.servus.at/aura/steering/-/issues/97
tmp_episode = data
let endpointShow = settings.api.endpoints.show
let showUrl = `${settings.api.url}/${endpointShow}/${data.show}`
......
......@@ -58,6 +58,7 @@
function processResponse(data) {
// Temporary workaround for o94
// #TODO Missing timeslots should be populated server-site
// @see https://gitlab.servus.at/aura/steering/-/issues/120
data = fillEmptyTimeslots(data, urlDefaultFallbackShow)
data = createtVirtualEndings(data)
/********************************/
......
......@@ -43,6 +43,7 @@
let hasMoreEpisodes = true
// #TODO AURA API - The API to fetch episodes is currently based on dates, the requested features are based on counts
// @see https://gitlab.servus.at/aura/steering/-/issues/97
/* Fetch more epsisodes for show */
function eventShowMore() {
......@@ -95,6 +96,7 @@
console.log('Error while loading episodes:', data.error)
// TODO This is a valid result - The final Aura API schould not return an error,
// but 0 records only
// @see https://gitlab.servus.at/aura/steering/-/issues/97
if (data.error.includes('No timeslots found')) {
console.log('No records for given timeframe, maybe there are past ones')
hasMoreEpisodes = true
......@@ -139,10 +141,12 @@
function processMoreEpisodes(data) {
if (data && data.error) {
// #FIXME API should handle 0 records not as an error / this case should compare for 0 records
// @see https://gitlab.servus.at/aura/steering/-/issues/97
hasMoreEpisodes = false
data = []
}
// #TODO The episodes should be provided ordered ascending by the API already (Ability to sort)
// @see https://gitlab.servus.at/aura/steering/-/issues/97
if (data != null && Array.isArray(data)) data = data.reverse()
if (episodes && Array.isArray(episodes)) {
......
......@@ -101,7 +101,7 @@
/* Filters shows by the first letter of its name */
function filterByName(response) {
// #TODO Such feature should be provided on AURA API side
// #TODO Such feature should be provided on AURA API side / review if that's still needed by o94?
let results = []
let url = new URL(window.location.href)
let filter = url.searchParams.get('letter')
......
......@@ -67,7 +67,7 @@
url={renderLinks ? episode.customUrl : null}
{renderHtml} />
{:else if hasEpisodeTitle(episode)}
<!-- #FIXME "emmission_ID" should be "timeslot_id", "episode_id" or "id" only -->
<!-- #FIXME "emmission_ID" should be "timeslot_id", "episode_id" or "id" only (@see steering#97) -->
<Display
value={episode.title}
url={renderLinks ? urlEpisodeDetail + episode.emission_ID : null}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment