Skip to content
Snippets Groups Projects
Commit 2eeb2ad6 authored by David Trattnig's avatar David Trattnig
Browse files

docs: add info on possible improvement

parent 6b90c82f
No related branches found
No related tags found
1 merge request!35ORM-less scheduling
......@@ -390,6 +390,11 @@ class Player:
queue (Boolean): If `True` the item is queued if the `ChannelType` does allow so;
otherwise a new channel of the same type is activated
TODO The command `item.play.set_playing()` sets the playlist item's status to _playing_
and assigns the current play start time. This is required for resource like line-in.
Other source like audio files have their start marker natively assigned by Liquidsoap.
These timestamp represent the actual real start time and should somehow be retrieved
from Liquidsoap, in order to also have the _real deal_ in Engine.
"""
with suppress(CoreConnectionError):
# Stop any active channel
......
......@@ -23,7 +23,6 @@ Event binding and propagation.
from __future__ import annotations
import datetime
import logging
from threading import Thread
......@@ -222,8 +221,6 @@ class EngineEventDispatcher:
def func(self, item: PlaylistItem):
self.logger.debug("on_play(..)")
# Assign timestamp indicating start play time. Use the actual playtime when possible.
item.play_start_time = datetime.datetime.now()
self.call_event("on_play", item)
thread = Thread(target=func, args=(self, item))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment