Missing timezone when timeslots are created via API (Dashboard)

changed milestone to %1.0-alpha2 — Precise Pheasant

assigned to @nnrcschmdt

@nnrcschmdt after the fix, it works, but there are still warnings in the logs:

Django version 2.2.12, using settings 'steering.settings'
Starting development server at http://127.0.0.1:8000/
Quit the server with CONTROL-C.
[15/Dec/2021 13:22:11] "GET /openid/.well-known/openid-configuration HTTP/1.1" 200 724
[15/Dec/2021 13:22:29] "GET /openid/userinfo HTTP/1.1" 200 143
[15/Dec/2021 13:22:29] "GET /api/v1/users/ HTTP/1.1" 200 2301
[15/Dec/2021 13:22:44] "GET /openid/userinfo HTTP/1.1" 200 143
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.end received a naive datetime (2021-12-15 00:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.start received a naive datetime (2021-12-15 00:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.start received a naive datetime (2021-12-22 00:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
Internal Server Error: /api/v1/playout
Traceback (most recent call last):
  File "/home/laura/venv-aura-python/lib/python3.9/site-packages/django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "/home/laura/venv-aura-python/lib/python3.9/site-packages/django/core/handlers/base.py", line 115, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/home/laura/venv-aura-python/lib/python3.9/site-packages/django/core/handlers/base.py", line 113, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/home/laura/steering/program/views.py", line 97, in json_playout
    is_repetition = ' ' + _('REP') if ts.schedule.is_repetition is True else ''
TypeError: can only concatenate str (not "__proxy__") to str
[15/Dec/2021 13:22:51] "GET /api/v1/playout HTTP/1.1" 500 77303
[15/Dec/2021 13:22:52] "GET /api/v1/ HTTP/1.1" 200 623
[15/Dec/2021 13:22:59] "GET /openid/userinfo HTTP/1.1" 200 143
[15/Dec/2021 13:23:35] "GET /api/v1/shows/ HTTP/1.1" 200 3198
[15/Dec/2021 13:23:35] "GET /api/v1/types/?active=true HTTP/1.1" 200 825
[15/Dec/2021 13:23:35] "GET /api/v1/fundingcategories/?active=true HTTP/1.1" 200 87
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.end received a naive datetime (2021-12-20 23:59:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.start received a naive datetime (2021-12-13 00:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
[15/Dec/2021 13:23:35] "GET /api/v1/timeslots/?start=2021-12-13&end=2021-12-20 HTTP/1.1" 200 1000
[15/Dec/2021 13:23:38] "GET /api/v1/timeslots/?start=2021-12-13&end=2021-12-20 HTTP/1.1" 200 1000
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.start received a naive datetime (2021-12-18 09:30:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.end received a naive datetime (2021-12-18 09:30:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.end received a naive datetime (2021-12-18 09:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1424: RuntimeWarning: DateTimeField TimeSlot.start received a naive datetime (2021-12-18 09:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s received a naive datetime (%s)"
[15/Dec/2021 13:23:42] "POST /api/v1/shows/5/schedules/ HTTP/1.1" 200 451
/home/laura/venv-aura-python/lib/python3.9/site-packages/django/db/models/fields/__init__.py:1366: RuntimeWarning: DateTimeField TimeSlot.start received a naive datetime (2021-12-18 00:00:00) while time zone support is active.
  warnings.warn("DateTimeField %s.%s received a naive datetime "
[15/Dec/2021 13:23:42] "POST /api/v1/shows/5/schedules/ HTTP/1.1" 201 243
[15/Dec/2021 13:23:42] "GET /api/v1/timeslots/?start=2021-12-13&en

added P3 label

added bug label

In 2022 maybe let's also discuss if we should make Dashboard "timezone-aware" and how we should handle it in general.

added discuss label

changed the description

added To Do label

@nnrcschmdt Playout currently doesn't work currently because http://localhost:8000/api/v1/playout provides schedules with wrong times. Since every record is 1 hour before the current time, I guess this relates to that ticket:

[
  {
    "id": 1,
    "start": "2022-01-14T16:50:00",
    "end": "2022-01-14T17:00:00",
    "title": "Musikprogramm",
    "automation-id": -1,
    "schedule_id": 1,
    "is_repetition": false,
    "playlist_id": 1,
    "schedule_default_playlist_id": null,
    "show_default_playlist_id": null,
    "show_id": 1,
    "show_name": "Musikprogramm",
    "show_hosts": "Musikredaktion",
    "show_type": "Unmoderiertes Musikprogramm",
    "show_categories": "",
    "show_topics": "",
    "show_musicfocus": "",
    "show_languages": "",
    "show_fundingcategory": "Standard",
    "memo": "",
    "className": "default"
  },
  {
    "id": 2,
    "start": "2022-01-14T17:05:00",
    "end": "2022-01-14T17:10:00",
    "title": "Musikprogramm",
    "automation-id": -1,
    "schedule_id": 2,
    "is_repetition": false,
    "playlist_id": 1,
    "schedule_default_playlist_id": null,
    "show_default_playlist_id": null,
    "show_id": 1,
    "show_name": "Musikprogramm",
    "show_hosts": "Musikredaktion",
    "show_type": "Unmoderiertes Musikprogramm",
    "show_categories": "",
    "show_topics": "",
    "show_musicfocus": "",
    "show_languages": "",
    "show_fundingcategory": "Standard",
    "memo": "",
    "className": "default"
  }
]

System Date/Time:

engine$ date Fr 14 Jän 2022 18:10:17 CET


Steering has the default TZ setting but it seems not being set to the actual schedules:

`TIME_ZONE = env.str('TIME_ZONE', default='Europe/Vienna')`

added Doing label and removed To Do label

added To Do label and removed Doing label

mentioned in issue dashboard#88 (closed)

marked this issue as related to dashboard#88 (closed)

added Doing label and removed To Do label

removed Doing label

closed

reopened

added Doing label

Reopen: Creating timeslots via Dashboard Calendar View results in "Could not read timeslots" from Steering.

Steering logs:

[11/Feb/2022 12:09:05] "POST /api/v1/shows/1/schedules/ HTTP/1.1" 200 450
django             | Internal Server Error: /api/v1/shows/1/schedules/
django             | Traceback (most recent call last):
django             |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
django             |     response = get_response(request)
django             |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
django             |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
django             |   File "/usr/local/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
django             |     return view_func(*args, **kwargs)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
django             |     return self.dispatch(request, *args, **kwargs)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
django             |     response = self.handle_exception(exc)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
django             |     self.raise_uncaught_exception(exc)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
django             |     raise exc
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
django             |     response = handler(request, *args, **kwargs)
django             |   File "/steering/program/views.py", line 449, in create
django             |     resolution = Schedule.resolve_conflicts(request.data, pk, show_pk)
django             |   File "/steering/program/models.py", line 740, in resolve_conflicts
django             |     if timezone.make_aware(datetime.strptime(ts['start'], "%Y-%m-%d %H:%M:%S")) <= timezone.now():
django             |   File "/usr/local/lib/python3.8/_strptime.py", line 568, in _strptime_datetime
django             |     tt, fraction, gmtoff_fraction = _strptime(data_string, format)
django             |   File "/usr/local/lib/python3.8/_strptime.py", line 352, in _strptime
django             |     raise ValueError("unconverted data remains: %s" %
django             | ValueError: unconverted data remains: +01:00
django             | ERROR:django.request:Internal Server Error: /api/v1/shows/1/schedules/
django             | Traceback (most recent call last):
django             |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
django             |     response = get_response(request)
django             |   File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
django             |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
django             |   File "/usr/local/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
django             |     return view_func(*args, **kwargs)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
django             |     return self.dispatch(request, *args, **kwargs)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
django             |     response = self.handle_exception(exc)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
django             |     self.raise_uncaught_exception(exc)
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
django             |     raise exc
django             |   File "/usr/local/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
django             |     response = handler(request, *args, **kwargs)
django             |   File "/steering/program/views.py", line 449, in create
django             |     resolution = Schedule.resolve_conflicts(request.data, pk, show_pk)
django             |   File "/steering/program/models.py", line 740, in resolve_conflicts
django             |     if timezone.make_aware(datetime.strptime(ts['start'], "%Y-%m-%d %H:%M:%S")) <= timezone.now():
django             |   File "/usr/local/lib/python3.8/_strptime.py", line 568, in _strptime_datetime
django             |     tt, fraction, gmtoff_fraction = _strptime(data_string, format)
django             |   File "/usr/local/lib/python3.8/_strptime.py", line 352, in _strptime
django             |     raise ValueError("unconverted data remains: %s" %
django             | ValueError: unconverted data remains: +01:00
django             | [11/Feb/2022 12:09:05] "POST /api/v1/shows/1/schedules/ HTTP/1.1" 500 105556

This should be fixed by now

closed

removed Doing label

marked this issue as related to #116 (closed)

removed discuss label

Missing timezone when timeslots are created via API (Dashboard)

Designs

Child items ...

Activity