From b7cf5f6c15cccb46f7fe6e8951288bac477da67e Mon Sep 17 00:00:00 2001
From: Ernesto Rico Schmidt <ernesto@helsinki.at>
Date: Fri, 9 Jun 2023 17:25:29 -0400
Subject: [PATCH] fix: ignore keys in fillter if values are empty
---
program/views.py | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/program/views.py b/program/views.py
index f349fe1d..38c91b7a 100644
--- a/program/views.py
+++ b/program/views.py
@@ -379,7 +379,9 @@ class APIShowViewSet(DisabledObjectPermissionCheckMixin, viewsets.ModelViewSet):
for key, value in request.query_params.items():
# map query parameters to filter names
- if key == "host_ids" or key == "owner_ids":
+ if value == "":
+ pass
+ elif key == "host_ids" or key == "owner_ids":
if value.count(",") > 0:
filter_kwargs[f"{key[:-4]}s__id__in"] = value.split(",")
else:
@@ -809,7 +811,9 @@ class APINoteViewSet(
# map query parameters to filter names
for key, value in request.query_params.items():
- if key == "ids":
+ if value == "":
+ pass
+ elif key == "ids":
if value.count(",") > 0:
filter_kwargs["id__in"] = value.split(",")
else:
@@ -831,6 +835,7 @@ class APINoteViewSet(
filter_kwargs[f"{key[:-4]}"] = value
else:
filter_kwargs[key] = value
+
try:
queryset = get_list_or_404(self.get_queryset(), **filter_kwargs)
except FieldError:
--
GitLab