From a254d0f7741a2630fa4ac409f5df75b1b01fca07 Mon Sep 17 00:00:00 2001 From: Ernesto Rico Schmidt <ernesto@helsinki.at> Date: Mon, 19 Feb 2024 18:57:17 -0400 Subject: [PATCH] =?UTF-8?q?fix:=20remove=20usage=20of=20SerializerMethod.?= =?UTF-8?q?=20They=20can=E2=80=99=C5=A7=20be=20updated?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- program/serializers.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/program/serializers.py b/program/serializers.py index cc6927ed..c2ddc568 100644 --- a/program/serializers.py +++ b/program/serializers.py @@ -474,7 +474,6 @@ class ShowSerializer(serializers.HyperlinkedModelSerializer): image_id = serializers.PrimaryKeyRelatedField( allow_null=True, queryset=Image.objects.all(), required=False ) - internal_note = serializers.SerializerMethodField() language_ids = serializers.PrimaryKeyRelatedField( many=True, queryset=Language.objects.all(), source="language" ) @@ -530,13 +529,6 @@ class ShowSerializer(serializers.HyperlinkedModelSerializer): "type_id", ) + read_only_fields - def get_internal_note(self, obj) -> str: - """Only users with the permission can see the internal note.""" - - user = self.context.get("request").user - - return obj.internal_note if user and user.has_perm("display__show__internal_note") else "" - def create(self, validated_data): """ Create and return a new Show instance, given the validated data. -- GitLab