From 363685e4787675ab10b3de44bed5ddca9bf3d8c4 Mon Sep 17 00:00:00 2001 From: Ernesto Rico Schmidt <ernesto@helsinki.at> Date: Fri, 9 Feb 2024 17:31:55 -0400 Subject: [PATCH] =?UTF-8?q?fix:=20use=20the=20instance=E2=80=99s=20value?= =?UTF-8?q?=20for=20timeslot,=20fix=20parenthesis?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- program/serializers.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/program/serializers.py b/program/serializers.py index fbbe045a..97b8e61c 100644 --- a/program/serializers.py +++ b/program/serializers.py @@ -1023,10 +1023,9 @@ class NoteSerializer(serializers.ModelSerializer): a show. """ - show = validated_data["timeslot"].schedule.show user = self.context.get("request").user user_is_privileged = user.groups.filter(name=settings.PRIVILEGED_GROUP).exists() - user_is_owner = user in show.owners + user_is_owner = user in instance.timeslot.schedule.show.owners # Only privileged users and owners of a show are allowed to update a note # Being a privileged user overrides the ownership @@ -1050,7 +1049,7 @@ class NoteSerializer(serializers.ModelSerializer): instance.language.set(language) # Only update this field if the user is privileged, ignore otherwise - if topic := validated_data.get("topic") and user_is_privileged: + if (topic := validated_data.get("topic")) and user_is_privileged: instance.topic.set(topic) if cba_id := validated_data.get("cba_id"): -- GitLab