From 1b0f554681ed7f9bf4f447ba061331ee7877d737 Mon Sep 17 00:00:00 2001
From: Ernesto Rico Schmidt <ernesto@helsinki.at>
Date: Mon, 26 Feb 2024 16:36:18 -0400
Subject: [PATCH] refactor: remove unused slug field from Note
---
program/migrations/0082_remove_note_slug.py | 16 ++++++++++++++++
program/models.py | 2 --
program/serializers.py | 5 -----
3 files changed, 16 insertions(+), 7 deletions(-)
create mode 100644 program/migrations/0082_remove_note_slug.py
diff --git a/program/migrations/0082_remove_note_slug.py b/program/migrations/0082_remove_note_slug.py
new file mode 100644
index 00000000..0d16d443
--- /dev/null
+++ b/program/migrations/0082_remove_note_slug.py
@@ -0,0 +1,16 @@
+# Generated by Django 4.2.10 on 2024-02-26 20:17
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+ dependencies = [
+ ("program", "0081_remove_note_owner"),
+ ]
+
+ operations = [
+ migrations.RemoveField(
+ model_name="note",
+ name="slug",
+ ),
+ ]
diff --git a/program/models.py b/program/models.py
index 13a9db79..3547ff27 100644
--- a/program/models.py
+++ b/program/models.py
@@ -467,8 +467,6 @@ class Note(models.Model):
image = models.ForeignKey(Image, null=True, on_delete=models.CASCADE, related_name="notes")
language = models.ManyToManyField(Language, blank=True, related_name="episodes")
playlist = models.TextField(blank=True)
- # TODO: this requires show in the model and an unique_together constraint. Do we need this?
- slug = models.SlugField(blank=True, max_length=32)
summary = models.TextField(blank=True)
tags = models.JSONField(blank=True, default=list)
timeslot = models.OneToOneField(TimeSlot, null=True, on_delete=models.SET_NULL, unique=True)
diff --git a/program/serializers.py b/program/serializers.py
index ee4910b0..30adfc82 100644
--- a/program/serializers.py
+++ b/program/serializers.py
@@ -998,7 +998,6 @@ class NoteSerializer(serializers.ModelSerializer):
"language_ids",
"links",
"playlist_id",
- "slug",
"summary",
"tags",
"timeslot_id",
@@ -1074,7 +1073,6 @@ class NoteSerializer(serializers.ModelSerializer):
if not (user.is_superuser or user_is_owner):
raise exceptions.PermissionDenied(detail="You are not allowed to update this note.")
- print(validated_data)
if "cba_id" in validated_data:
instance.cba_id = validated_data.get("cba_id")
@@ -1084,9 +1082,6 @@ class NoteSerializer(serializers.ModelSerializer):
if "image" in validated_data:
instance.image = validated_data.get("image")
- if "slug" in validated_data:
- instance.slug = validated_data.get("slug")
-
if "summary" in validated_data:
instance.summary = validated_data.get("summary")
--
GitLab