engine-api merge requestshttps://gitlab.servus.at/aura/engine-api/-/merge_requests2024-03-08T10:29:08+01:00https://gitlab.servus.at/aura/engine-api/-/merge_requests/35feat: add gitlab issue templates2024-03-08T10:29:08+01:00David Trattnigfeat: add gitlab issue templatesSee https://gitlab.servus.at/aura/aura/-/issues/319+See https://gitlab.servus.at/aura/aura/-/issues/319+David TrattnigDavid Trattnighttps://gitlab.servus.at/aura/engine-api/-/merge_requests/34Fix docker image names for release2024-02-28T17:00:23+01:00Chris PastlFix docker image names for releaseThis reverts commit bbbebfdcf285536c7497f316b699df53fc21bb94 and renames the pushed image to 'main' instead of 'unstable' again. As discussed in matrix.This reverts commit bbbebfdcf285536c7497f316b699df53fc21bb94 and renames the pushed image to 'main' instead of 'unstable' again. As discussed in matrix.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/33docs: update changelog for alpha32024-02-21T16:38:15+01:00Chris Pastldocs: update changelog for alpha3https://gitlab.servus.at/aura/engine-api/-/merge_requests/32fix: adapt envar naming2024-02-21T01:02:23+01:00Chris Pastlfix: adapt envar naminghttps://gitlab.servus.at/aura/engine-api/-/merge_requests/31feat(DOCKER): Use docker main tag2024-01-31T13:35:51+01:00Kay Effenbergerfeat(DOCKER): Use docker main taghttps://gitlab.servus.at/aura/aura/-/issues/149https://gitlab.servus.at/aura/aura/-/issues/149Kay EffenbergerKay Effenbergerhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/30fix: add missing envars to docker config2024-01-18T00:24:22+01:00Chris Pastlfix: add missing envars to docker config1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/29Use explicit string for default database password in order to avoid parsing e...2024-01-15T20:09:14+01:00Chris PastlUse explicit string for default database password in order to avoid parsing errorsI decided to change the default database password to an explicit string because `1234` evaluates to int and adding quotes `'1234'` resulted in some confusing errors.
Related to #54
@david Please let me know if you see some downsides o...I decided to change the default database password to an explicit string because `1234` evaluates to int and adding quotes `'1234'` resulted in some confusing errors.
Related to #54
@david Please let me know if you see some downsides or broken dependencies of this change so that we can revert and improve it.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/28Review gunicorn settings #362023-09-20T00:25:30+02:00Chris PastlReview gunicorn settings #36Got more familiar with gunicorn by reading the docs and finding some best practices concerning tuning and optimization.
- adjusted worker count to `cpu_count() * 2 + 1` (seems to be a good choice for most applications, see docs)
- incre...Got more familiar with gunicorn by reading the docs and finding some best practices concerning tuning and optimization.
- adjusted worker count to `cpu_count() * 2 + 1` (seems to be a good choice for most applications, see docs)
- increased `keep_alive` (for reverse proxy)
- logs are written to the common log directory (`logs/gunicorn_access.log`, `logs/gunicorn_error.log`)
Other settings should be adjusted individually.
Running locally and using docker succeeded without issues and requests were logged to the according files.
Also changed makefile so that the `cp` command won't exit the script (if file already exists)1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/27fix: typo in comment2023-08-23T00:39:43+02:00Chris Pastlfix: typo in commenthttps://gitlab.servus.at/aura/engine-api/-/merge_requests/26Fix: Load envars as config override2023-08-23T00:26:29+02:00Chris PastlFix: Load envars as config overrideNeeded to switch to an alternative approach injecting the envars because confuse's conventions would require adapting the envar naming which is not intended due to dependencies to other components.Needed to switch to an alternative approach injecting the envars because confuse's conventions would require adapting the envar naming which is not intended due to dependencies to other components.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/25Fix overriding yaml config with envars2023-08-21T16:52:21+02:00Chris PastlFix overriding yaml config with envarsAs described in #53, envars within the yaml config file are not being parsed and replaced by their values; so we're using confuse's built-in function `set_env()` for that.
NB: Needed to slightly adapt (docker) envar naming in order to c...As described in #53, envars within the yaml config file are not being parsed and replaced by their values; so we're using confuse's built-in function `set_env()` for that.
NB: Needed to slightly adapt (docker) envar naming in order to conform to confuse conventions.Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/24Improve session handling #92023-08-10T03:18:11+02:00Chris PastlImprove session handling #9Created a session-factory bound to connexion's underlying sqlalchemy engine and instanciated 2 separate sessions - each for api and sync.
Tests for setting/getting active source succeeded, so assuming that there is no need of calling co...Created a session-factory bound to connexion's underlying sqlalchemy engine and instanciated 2 separate sessions - each for api and sync.
Tests for setting/getting active source succeeded, so assuming that there is no need of calling commit() before the query.
Since each session is created in the according context / thread, this approach should also be thread-safe but couldnt verify yet.
Need to retest, thus marking this mr to draft.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/23API: change datatype for trackDuration to float #512024-01-13T00:56:12+01:00Chris PastlAPI: change datatype for trackDuration to float #51Changed trackDuration to float by modifying the api spec, running make api and discarding unneccessary overwrites.
@david Decided to keep type annotations and singlequoted strings in affacted files. Anyhow, flake rewrites some swagger ...Changed trackDuration to float by modifying the api spec, running make api and discarding unneccessary overwrites.
@david Decided to keep type annotations and singlequoted strings in affacted files. Anyhow, flake rewrites some swagger conventions again, so there could be done some finetuning in the future to keep the changes as low as possible.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/22Unit Test for track titles containing emojis2023-07-24T14:29:09+02:00Chris PastlUnit Test for track titles containing emojisTest if track titles containing emojis are encoded correctly. Succeeds both on postgres and sqlite.Test if track titles containing emojis are encoded correctly. Succeeds both on postgres and sqlite.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/21OpenAPI Generator #372023-07-24T15:57:00+02:00Chris PastlOpenAPI Generator #37Added command `make api` which executes 3 subcommands for generating, merging and cleaning api files. Each command can be called separately as well:
- `make api.gen` generate files according to `./schemas/openapi-engine.yaml` and save o...Added command `make api` which executes 3 subcommands for generating, merging and cleaning api files. Each command can be called separately as well:
- `make api.gen` generate files according to `./schemas/openapi-engine.yaml` and save output in `./swagger_codegen_out`
- `make api.merge` run `git merge-file` on all files in `controllers`, `models` and `tests`
- `make api.clean` remove auto-generated directory `./swagger_codegen_out`
@david Not sure if there’s a better merging approach - should we keep it?1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/20YAML Config2023-07-20T20:10:15+02:00Chris PastlYAML ConfigImplemented yaml config file loading and -validation by integrating `confuse` module.Implemented yaml config file loading and -validation by integrating `confuse` module.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/19Remove obsolete endpoint #482023-06-28T00:35:18+02:00Chris PastlRemove obsolete endpoint #48Removed obsolete endpoint `/playlog/report/{year_month}` as described in #48.Removed obsolete endpoint `/playlog/report/{year_month}` as described in #48.1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/18Final fixes for 1.0.0 alpha22023-06-26T17:35:20+02:00Chris PastlFinal fixes for 1.0.0 alpha2Need to merge 2 important fixes for alpha2:
- dockerfile: copy `./schemas` to `/srv/schemas`
- makefile: fix `release` commandNeed to merge 2 important fixes for alpha2:
- dockerfile: copy `./schemas` to `/srv/schemas`
- makefile: fix `release` command1.0-alpha2 — ⚖️🐦 Precise PheasantChris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/17Fix changelog for release 1.0.0 alpha22023-06-22T11:58:35+02:00Chris PastlFix changelog for release 1.0.0 alpha2Fix changelog as discussed with @david:
- fix typo
- remove non-relevant changes from user perspectiveFix changelog as discussed with @david:
- fix typo
- remove non-relevant changes from user perspective1.0-alpha2 — ⚖️🐦 Precise PheasantChris PastlChris Pastlhttps://gitlab.servus.at/aura/engine-api/-/merge_requests/16Release 1.0.0-alpha22023-06-19T22:36:38+02:00Chris PastlRelease 1.0.0-alpha2- increase version to "1.0.0-alpha2"
- update changelog- increase version to "1.0.0-alpha2"
- update changelog1.0-alpha3 — Playful Platypus ▶️🦦Chris PastlChris Pastl